perf(refactor): consolidate getState calls in resolveWebviewView #11318
+22
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xMink
requested review from
cte,
daniel-lxs,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
the
size:M
Contributor
Reviewed 5519dcd against the previous review at e69da98. The consolidation of three Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Replace three separate this.getState().then() calls with a single await this.getState() and destructuring. This avoids running the full getState() method (CloudService calls, ContextProxy reads, etc.) three times during webview view resolution.
Contributor
No issues found. The consolidation of three Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
0xMink
force-pushed
the
perf/consolidate-getstate-resolvewebview
branch
from
e69da98 to
5519dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this.getState().then(...)calls into a singleawait this.getState()with destructuring inresolveWebviewView()getState()which includes CloudService calls, ContextProxy reads, and other workTest plan
ClineProvider.spec.tstests pass (90/90, 6 skipped unchanged)Important
Refactor
resolveWebviewViewinClineProvider.tsto consolidate multiplegetStatecalls into a single call, improving performance without changing behavior.this.getState().then(...)calls into a singleawait this.getState()inresolveWebviewView()inClineProvider.ts.getState()executions.ClineProvider.spec.tspass (90/90, 6 skipped unchanged).This description was created by
for e69da98. You can customize this summary. It will automatically update as commits are pushed.